Repository navigation
fix: contain unexpected CLI panics - #97
Merged
Merged
Conversation
Return exit 70 without exposing panic payloads or build paths. Keep normal dispatch output and panic hooks on other threads unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Catch unwinding panics at CLI entry and return the documented exit 70 with one
stderr line,
atx: unexpected internal failure. Keep panic payloads, build paths,and backtraces out of that diagnostic, including JSON and verbose requests.
Keep normal dispatch results and other threads' panic hooks unchanged. Do not
resume application work after a caught panic. A hostile panic payload destructor
cannot replace the intended failure with another panic.
Isolated process tests cover the panic exit and exact diagnostic, resource
cleanup, payload destructors, normal help/version/typed/JSON errors, and hook
scope. Both guides describe the panic exception and its unwind-only limit.
Checks
exit 101 instead of 70. Restored implementation passes all seven focused tests.
scripts/check.sh fullat1d194d0: 552 tests and all normal static,documentation, dependency, package, and publish-dry-run stages passed.
with actual Rust 1.85 and a fresh consumer target: 461 bin tests passed,
including all seven boundary tests. Source and VCS metadata match the head.
All required and additional current-head checks must pass before merge.
No publication, tags, repository settings, or branch cleanup.